Skip to content

Display stack duration in profiler #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2017
Merged

Display stack duration in profiler #157

merged 1 commit into from
May 3, 2017

Conversation

fbourigault
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets fixes #156
Documentation N/A
License MIT

This add the stack duration in the profiler.

httplugbundle4

@fbourigault fbourigault added this to the Version 1.5.0 milestone May 2, 2017
@Nyholm Nyholm self-requested a review May 2, 2017 10:24
@@ -80,6 +80,11 @@
font-size: 12px;
}

.httplug-duration {
min-width: 6ch;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ch"? What is that?

Someone once told me to always use "rem".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 ch is the width of a "0" in the current font. It looks easier to me as I want the box at least large as if it was filled with 6 characters.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm. Interesting. Thanks.

What if it takes more then one sec? "1000 ms" That is 7 chars, right? Will we get a line break? If so, change this to 7ch and we will be all happy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use number_format twig filter, so you get a thousand separator. But anyway, I set this as a min-width to get the same width when duration is lower than 100ms and lower than 1000ms. When duration is over 1000ms, the box get larger.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. It was e reading this to fast. It is all good then =)

@Nyholm Nyholm merged commit dace014 into php-http:master May 3, 2017
@Nyholm
Copy link
Member

Nyholm commented May 3, 2017

Thank you.

@fbourigault fbourigault deleted the display-stack-duration-in-profiler branch May 3, 2017 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display the stack duration in the profiler stack header
3 participants